Skip to content

Conversation

@zeahmed
Copy link
Contributor

@zeahmed zeahmed commented Mar 28, 2019

Related to #1209.

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #3133 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3133      +/-   ##
==========================================
- Coverage   72.52%   72.51%   -0.01%     
==========================================
  Files         808      808              
  Lines      144665   144665              
  Branches    16198    16198              
==========================================
- Hits       104913   104911       -2     
- Misses      35342    35343       +1     
- Partials     4410     4411       +1
Flag Coverage Δ
#Debug 72.51% <ø> (-0.01%) ⬇️
#production 68.11% <ø> (-0.01%) ⬇️
#test 88.81% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Transforms/Text/TextCatalog.cs 41.66% <ø> (ø) ⬆️
...StandardTrainers/Standard/LinearModelParameters.cs 60.05% <0%> (-0.27%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.21%) ⬇️

Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

public string NormalizedText { get; set; }
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zeahmed
Copy link
Contributor Author

zeahmed commented Apr 1, 2019

Thanks!

@zeahmed zeahmed closed this Apr 1, 2019
@zeahmed zeahmed reopened this Apr 1, 2019
@zeahmed zeahmed merged commit f93e973 into dotnet:master Apr 1, 2019
zeahmed added a commit to zeahmed/machinelearning that referenced this pull request Apr 8, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants