Renaming IterationsToRemember to HistorySize for L-BFGS learners. #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It's always EntryPointCatalog |
artidoro
approved these changes
Mar 9, 2019
wschin
reviewed
Mar 9, 2019
| [TGUI(Description = "Memory size for L-BFGS", SuggestedSweeps = "5,20,50")] | ||
| [TlcModule.SweepableDiscreteParamAttribute("MemorySize", new object[] { 5, 20, 50 })] | ||
| public int IterationsToRemember = Defaults.IterationsToRemember; | ||
| public int HistorySize = Defaults.HistorySize; |
Member
There was a problem hiding this comment.
nit:
Suggested change
| public int HistorySize = Defaults.HistorySize; | |
| public int HistoryLength = Defaults.HistorySize; |
Size sounds like the number of parameters we can store.
Contributor
Author
|
Oops, just saw your comment. HistorySize is the common nomenclature, and also used by PyTorch. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the L-BFGS parameter
IterationsToRemembertoHistorySizeto be more in line with the common nomenclature. (Previously it wasMemorySize.)Fixes #2882