Scrubbing schema related transforms #2863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFinley
changed the title
wschin
reviewed
Mar 5, 2019
| public bool KeepHidden { get; } | ||
| public bool IgnoreMissing { get; } | ||
| internal bool KeepHidden { get; } | ||
| internal bool IgnoreMissing { get; } |
Member
There was a problem hiding this comment.
Do we really need to hide them? They are some direct states of public options.
Contributor
Author
There was a problem hiding this comment.
Maybe it just me been paranoid and I want to hide everything I can.
On other hand we need to provide this information for each transformer, like term dictionary or list of columns we been concatenating for concat, and we don't have conclusion how to do it yet.
Codecov Report
@@ Coverage Diff @@
## master #2863 +/- ##
==========================================
+ Coverage 71.69% 71.69% +<.01%
==========================================
Files 809 809
Lines 142444 142444
Branches 16109 16109
==========================================
+ Hits 102126 102130 +4
+ Misses 35891 35889 -2
+ Partials 4427 4425 -2
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2828