-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update of FeatureContributionCalculation to new API #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/samples/Microsoft.ML.Samples/Dynamic/FeatureContributionCalculationTransform.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
rogancarr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a non-technical pass over to look at usability. Overall, this looks good! Mostly, I'd like to make sure we can use it in pipelines and that we have tests that cover the options and the implementations. (Although maybe implementation tests can be a separate PR.)
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
f969628 to
74d6581
Compare
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/FeatureContributionCalculationTransform.cs
Outdated
Show resolved
Hide resolved
I think we tend to put results of output into comments for the file. #Resolved Refers to: docs/samples/Microsoft.ML.Samples/Dynamic/FeatureContributionCalculationTransform.cs:87 in a62a510. [](commit_id = a62a510, deletion_comment = False) |
…nals, and test fixes
Fixes #1791.
As this is a WIP PR, I am still completing the work, but I would really appreciate your feedback on what I have done so far.
In this PR:
Will do in a separate PR: