Remove unused tasks and clearinitlocals optimization #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marek-safar
reviewed
Jun 25, 2020
eerhardt
approved these changes
Jun 25, 2020
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Looks good, after the type-o @marek-safar pointed out is fixed.
| /// Boolean specifying whether to enable clearinitlocals optimization globally. | ||
| /// Maps to '--enable-opt clearinitlocals' or '--disable-opt clearinitlocals'. | ||
| /// </summary> | ||
| public bool ClearInitLocals { set => _clearInitLocals = value; } |
Member
There was a problem hiding this comment.
Note that once you remove this, the line in the SDK that sets this is going to fail when the new ILLink task version is brought in:
Member
Author
There was a problem hiding this comment.
Like #1292, I'll wait for the SDK changes to flow into the linker, to get the integration tests passing.
sbomer
added a commit
to sbomer/sdk
that referenced
this pull request
Jun 25, 2020
marek-safar
approved these changes
Jun 25, 2020
sbomer
added a commit
to dotnet/sdk
that referenced
this pull request
Jun 29, 2020
* Remove unsupported linker argument See dotnet/linker#1295 * Also remove test
sbomer
force-pushed
the
cleanupUnusedCode
branch
from
4f42ca4 to
2753a38
Compare
These were used in the MSBuild logic that shipped with the OOB ILLink.Tasks. They are no longer used now that the linker ships with the SDK.
sbomer
force-pushed
the
cleanupUnusedCode
branch
from
2753a38 to
7cb82a9
Compare
tkapin
pushed a commit
to tkapin/runtime
that referenced
this pull request
Jan 31, 2023
) * Remove unused tasks These were used in the MSBuild logic that shipped with the OOB ILLink.Tasks. They are no longer used now that the linker ships with the SDK. * Remove ClearInitLocals optimization Fixes dotnet/linker#1256 * Fix build and typo Commit migrated from dotnet/linker@c019f7a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eerhardt pointed out that blazor was using some logic copied from one of our unused tasks, left over from when we shipped ILLink.Tasks OOB. This removes the unused tasks.
Also removes the unused clearinitlocals optimization. Fixes #1256.