[generator] Fix <remove-attr> metadata. #999
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #976.
Given an
api.xmlelement like:You would expect to be able to remove the
api-sinceattribute with this metadata:However, even though
generatorreads thenameattribute, it then proceeds to ignore it and remove all attributes on the matched node, resulting in:This seems unintuitive, and I'm not sure how this could ever be successfully used in a binding project, since leaving an empty
<class>, etc. node causesgeneratorto crash.Fix
<remove-attr>to work as expected.