[generator] make sure to escape non-generic parameter name for calls. #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes bug #46454. Parameter ToNative() was not escaping C# identifiers, and then it sometimes resulted in invalid C# code. It can be easily workarounded by metadata fixup, but also fixable.
jonpryor
pushed a commit
that referenced
this pull request
Oct 20, 2020
Changes: dotnet/android-tools@f2af06f...26d65d9 * dotnet/android-tools@26d65d9: [Xamarin.Android.Tools.AndroidSdk] Update SDK component for API-30 (#99) * dotnet/android-tools@1878e43: [Xamarin.Android.Tools.AndroidSdk] Error & Warning Localization (#96) Additionally, the "main" branch for xamarin/xamarin-android-tools has changed from xamarin-android-tools/master to xamarin-android-tools/main. Update `.gitmodules` accordingly. Finally, update the `nuget restore Xamarin.Android.Tools.sln` command executed by `azure-pipelines.yaml` to also provide `-ConfigFile external\xamarin-android-tools\NuGet.config` in order to prevent the following failure on CI: NU1101: Unable to find package XliffTasks. No packages exist with this id in source(s): NuGetOrg
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug #46454.
Parameter ToNative() was not escaping C# identifiers, and then it sometimes
resulted in invalid C# code.
It can be easily workarounded by metadata fixup, but also fixable.