[build] main targets .NET 7
#978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#962 Context: 3851b1a Context: dotnet#936 Context: dotnet#975 We have several PRs which impact public API, and we want to land as part of .NET 7, and *not* as part of .NET 6, e.g. dotnet#936. Update `GitInfo.txt` to `7.0`, and update `$(_NetCoreLibVersion)` to be `$(GitBaseVersionMajor).$(GitBaseVersionMinor).0.0` -- reverting commit 3851b1a -- as an indicator that from this point onward, all work on `main` is targeting .NET 7.
Contributor
Note that this PR does not make That is, it does not have CI install a build of .NET 7, and it does not update any assemblies to target Should those changes go with this PR? Or are we ok letting that come later? |
Contributor
Author
In an ideal world, yes. Unfortunately, I don't know what that looks like/how to do that, so…
In the interest of "expediency" -- as I'd like to get #936 into xamarin-android once it is targeting .NET 7 (dotnet/android#6598) -- I'm fine with "letting [those changes] come later", so long as you are also OK with that. |
jpobst
approved these changes
May 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #962
Context: 3851b1a
Context: #936
Context: #975
We have several PRs which impact public API, and we want to land as
part of .NET 7, and not as part of .NET 6, e.g. #936.
Update
GitInfo.txtto7.0, and update$(_NetCoreLibVersion)tobe
$(GitBaseVersionMajor).$(GitBaseVersionMinor).0.0-- revertingcommit 3851b1a -- as an indicator that from this point onward, all
work on
mainis targeting .NET 7.