[build] Remove the make prepare-core targets
#951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `make prepare-core` target was added in 1de5501, as a "stopgap" to simplify adding support for building the xamarin/Java.Interop repo using .NET Core, as `MonoInfo.props` and `Java.Runtime.Environment.dll.config` were still required by various parts of the build system, but those files were only created via Makefile targets. `Java.Runtime.Environment.dll.config` generation was migrated to MSBuild in e02d857. Update `Java.Interop.BootstrapTasks.targets` so that `MonoInfo.props` is generated via MSBuild target. This removes the need to have a `make prepare-core` target at all.
jonpryor
force-pushed
the
jonp-remove-prepare-core
branch
from
00df56b to
8fff6a9
Compare
jpobst
approved these changes
Feb 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
make prepare-coretarget was added in 1de5501, as a "stopgap"to simplify adding support for building the xamarin/Java.Interop
repo using .NET Core, as
MonoInfo.propsandJava.Runtime.Environment.dll.configwere still required by variousparts of the build system, but those files were only created via
Makefile targets.
Java.Runtime.Environment.dll.configgeneration was migrated toMSBuild in e02d857.
Update
Java.Interop.BootstrapTasks.targetsso thatMonoInfo.propsis generated via MSBuild target. This removes the need to have a
make prepare-coretarget at all.