[build] Fix the invocation-overhead build.
#93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsushieno
reviewed
Oct 6, 2016
build-tools/scripts/mono.mk
Outdated
| @@ -1,3 +1,31 @@ | |||
| # | |||
| # JDK Path Probing | |||
Contributor
There was a problem hiding this comment.
Maybe this is some copy-pasting obstacle?
Contributor
|
Almost LGTM. If you add cosmetic fix for my comment I'll wait. Or will just merge tomorrow. |
The `tests/invocation-overhead` build had regressed, largely becuase it's rarely executed. Breakage was due to the fact that the JNI headers could no longer be found, and that when running `make run`, the "wrong" mono was being used wrt the JVM that was used (e.g. trying to use a 32-bit mono with a 64-bit JVM). Refactor some Makefile logic and cleanup for consistency.
jonpryor
force-pushed
the
jonp-fix-invocation-overheads
branch
from
0bf7f8f to
036faae
Compare
jonpryor
pushed a commit
that referenced
this pull request
Sep 25, 2020
Changes: dotnet/android-tools@3974fc3...f2af06f * dotnet/android-tools@f2af06f: [Xamarin.Android.Tools.AndroidSdk] Fix a few nullability warnings (#97) * dotnet/android-tools@5718cd2: Fix sort ordering for ndk-bundle, add macOS support (#91) * dotnet/android-tools@8e63795: [Xamarin.Android.Tools.AndroidSdk] Add API-29, API-30 to KnownVersions (#89) * dotnet/android-tools@a6a23bb: [Xamarin.Android.Tools.AndroidSdk] Default SDK component versions (#93) * dotnet/android-tools@32a1e2c: [build] fail macOS build if tests fail (#94) * dotnet/android-tools@79a0141: Return a default for unknown API levels (#90)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tests/invocation-overheadbuild had regressed, largely becuaseit's rarely executed. Breakage was due to the fact that the JNI
headers could no longer be found, and that when running
make run,the "wrong" mono was being used wrt the JVM that was used (e.g. trying
to use a 32-bit mono with a 64-bit JVM).
Refactor some Makefile logic and cleanup for consistency.