[Xamarin.Android.Tools.Bytecode] Fix Nullability warnings #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 77c9c5f Commit 77c9c5f inadvertently introduced nullability warnings: …\Xamarin.Android.Tools.Bytecode\ClassPath.cs(308,89): warning CS8600: Converting null literal or possible null value to non-nullable type. …\Xamarin.Android.Tools.Bytecode\ClassPath.cs(308,54): warning CS8604: Possible null reference argument for parameter 'jniType' in 'JavaMethodParameterTypeInfo.JavaMethodParameterTypeInfo(string jniType, string javaType)'. …\Xamarin.Android.Tools.Bytecode\ClassPath.cs(308,89): warning CS8604: Possible null reference argument for parameter 'javaType' in 'JavaMethodParameterTypeInfo.JavaMethodParameterTypeInfo(string jniType, string javaType)'. …\Xamarin.Android.Tools.Bytecode\ClassPath.cs(318,8): warning CS8600: Converting null literal or possible null value to non-nullable type. …\Xamarin.Android.Tools.Bytecode\JavaDocumentScraper.cs(403,19): warning CS8600: Converting null literal or possible null value to non-nullable type. …\Xamarin.Android.Tools.Bytecode\JavaDocumentScraper.cs(405,19): warning CS8600: Converting null literal or possible null value to non-nullable type. …\Xamarin.Android.Tools.Bytecode\JavaDocumentScraper.cs(413,46): warning CS8600: Converting null literal or possible null value to non-nullable type. …\Xamarin.Android.Tools.Bytecode\JavaDocumentScraper.cs(419,58): warning CS8600: Converting null literal or possible null value to non-nullable type. …\Xamarin.Android.Tools.Bytecode\JavaDocumentScraper.cs(439,19): warning CS8600: Converting null literal or possible null value to non-nullable type. …\Xamarin.Android.Tools.Bytecode\JavaDocumentScraper.cs(438,11): warning CS8619: Nullability of reference types in value of type 'string?[]' doesn't match target type 'string[]'. …\Xamarin.Android.Tools.Bytecode\JavaDocumentScraper.cs(444,17): warning CS8600: Converting null literal or possible null value to non-nullable type. …\Xamarin.Android.Tools.Bytecode\JavaDocumentScraper.cs(445,10): warning CS8602: Dereference of a possibly null reference. Fix these nullability warnings.
jpobst
approved these changes
Nov 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 77c9c5f
Commit 77c9c5f inadvertently introduced nullability warnings:
Fix these nullability warnings.