[generator] emit UnconditionalSuppressMessage in __TypeRegistrations #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
typeregistrations-illink-warning
branch
from
15a881d to
8a5a548
Compare
Building a .NET MAUI app with `-p:SuppressTrimAnalysisWarnings=false
-p:TrimmerSingleWarn=false` shows the warning:
src\Compatibility\Android.FormsViewGroup\src\obj\Release\net6.0-android\generated\src\Java.Interop.__TypeRegistrations.cs(35,4):
error IL2057: Java.Interop.__TypeRegistrations.Lookup(String[],String): Unrecognized value passed to the parameter 'typeName' of method 'System.Type.GetType(String)'. It's not possible to guarantee the availability of the target type.
This code path should not even be used normally. It is only called
when running inside the Android designer.
For now, let's simply emit an extra attribute to ignore the warning:
[System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessage("Trimming", "IL2057")]
This attribute was added in .NET 5, so we can always emit the code and
use `#if NET5_0_OR_GREATER`.
jonathanpeppers
force-pushed
the
typeregistrations-illink-warning
branch
from
8a5a548 to
9fe3b82
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building a .NET MAUI app with
-p:SuppressTrimAnalysisWarnings=false -p:TrimmerSingleWarn=falseshows the warning:This code path should not even be used normally. It is only called
when running inside the Android designer.
For now, let's simply emit an extra attribute to ignore the warning:
This attribute was added in .NET 5, so we can always emit the code and
use
#if NET5_0_OR_GREATER.