[build] Copy Mono.Options.pdb to output directory #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1421424/ A recent update to Mono.Options.dll (presumably commit c936d09) has caused a symbol check failure in our latest VS insertion. We can fix this by updating one of the tools projects that references this package to copy Mono.Options.pdb to the Output directory. Once the file is in the right output path we can include it in the XA installers.
Member
Author
|
Testing this in dotnet/android#6407 |
Member
Author
|
Looks like installer creation succeeded so the 4.0 .pbd is getting to the right output dir in XA. I think this should be good to go. |
Contributor
|
I wonder why this started failing. Neither of the previous versions of Mono.Options NuGets we were using ( |
Member
Author
|
I think the previous version of Mono.Options in our installer was old enough that it already had symbols archived from some other insertion, so the particular file was never flagged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1421424/
A recent update to Mono.Options.dll (presumably commit c936d09) has
caused a symbol check failure in our latest VS insertion. We can fix
this by updating one of the tools projects that references this package
to copy Mono.Options.pdb to the Output directory. Once the file is in
the right output path we can include it in the XA installers.