Skip to content

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Mar 5, 2021

Fix some NRT warnings that have crept in.


Also add <NeutralLanguage>en</NeutralLanguage> to fix:

Warning CA1824: Mark assemblies with NeutralResourcesLanguageAttribute

Basically this says that the "neutral" language this assembly contains is also the English translations, so we don't need to spend time probing for satellite resource assemblies when the English language is requested.


Also add <MSBuildWarningsAsMessages>NU1702</MSBuildWarningsAsMessages> to suppress:

Warning NU1702: ProjectReference 'D:\a\1\s\src\java-interop\java-interop.csproj' was resolved using 
'.NETFramework,Version=v4.7.2' instead of the project target framework '.NETStandard,Version=v2.0'. 
This project may not be fully compatible with your project.

@jpobst jpobst marked this pull request as ready for review March 5, 2021 16:21
@jonpryor jonpryor merged commit daec07b into main Mar 6, 2021
@jonpryor jonpryor deleted the fix-warnings branch March 6, 2021 00:46
@jpobst jpobst added this to the 11.3 (16.10 / 8.10) milestone May 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants