[Java.Runtime.Environment] Fix CS0436 warnings #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#792 Commit cba6137 added `[assembly: InternalsVisibleTo]`, allowing the internal types from `Java.Interop.dll` to be seen from/used by `Java.Runtime.Environment.dll`, so that `MonoRuntimeValueManager` could use the type `JniLocationException`. The downside to this change is that types internal to `Java.Interop.dll` were visible to `Java.Runtime.Environment.dll`. Types such as `Java.Interop.NativeMethods`, which "conflicts" with `Java.Interop.NativeMethods` type in `Java.Runtime.Environment.dll`. The result: 31 CS0436 warnings were introduced with commit cba6137: Java.Interop/MonoRuntimeObjectReferenceManager.cs(16,14): warning CS0436: The type 'NativeMethods' in '…/src/Java.Runtime.Environment/Java.Interop/JreRuntime.cs' conflicts with the imported type 'NativeMethods' in 'Java.Interop, Version=0.1.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065'. Using the type defined in '…/src/Java.Runtime.Environment/Java.Interop/JreRuntime.cs'. Fix these warnings by *removing* the `[assembly: InternalsVisibleTo]` added in cba6137, and copy `JniLocationException` into `Java.Runtime.Environment.dll`, renamed as `OverrideStackTrace`.
jpobst
approved these changes
Feb 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #792
Commit cba6137 added
[assembly: InternalsVisibleTo], allowing theinternal types from
Java.Interop.dllto be seen from/used byJava.Runtime.Environment.dll, so thatMonoRuntimeValueManagercould use the type
JniLocationException.The downside to this change is that types internal to
Java.Interop.dllwere visible toJava.Runtime.Environment.dll.Types such as
Java.Interop.NativeMethods, which "conflicts" withJava.Interop.NativeMethodstype inJava.Runtime.Environment.dll.The result: 31 CS0436 warnings were introduced with commit cba6137:
Fix these warnings by removing the
[assembly: InternalsVisibleTo]added in cba6137, and copy
JniLocationExceptionintoJava.Runtime.Environment.dll, renamed asOverrideStackTrace.