[build] fix env vars causing gradle build error #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#5044 (comment) Context: https://docs.microsoft.com/visualstudio/msbuild/exec-task An env var can break the build such as running the following powershell: > $env:FOO="`nFoo.cs(123,1) error: oh dear!" A `\n` new line in the string is required to hit an issue. This results in a confusing build error: (_BuildJava target) -> EXEC : Foo.cs(123,1) error : oh dear! `gradlew -d` emits every environment variable, and if there is a line that looks like an MSBuild error it will emit the error. We can set `IgnoreStandardErrorWarningFormat="true"` to disable this behavior. This could commonly happen on CI systems, if a commit message contains an error message. In the case of Azure DevOps, `%BUILD_SOURCEVERSIONMESSAGE%` will contain the full commit message. I also fixed the `_CleanJava` target that was not running at all. `java-source-utils.csproj` now properly cleans now.
jpobst
approved these changes
Sep 3, 2020
dellis1972
approved these changes
Sep 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#5044 (comment)
Context: https://docs.microsoft.com/visualstudio/msbuild/exec-task
An env var can break the build such as running the following powershell:
A
\nnew line in the string is required to hit an issue.This results in a confusing build error:
gradlew -demits every environment variable, and if there is a linethat looks like an MSBuild error it will emit the error. We can set
IgnoreStandardErrorWarningFormat="true"to disable this behavior.This could commonly happen on CI systems, if a commit message contains
an error message.
In the case of Azure DevOps,
%BUILD_SOURCEVERSIONMESSAGE%willcontain the full commit message.
I also fixed the
_CleanJavatarget that was not running at all.java-source-utils.csprojnow properly cleans now.