[jnimarshalmethod-gen] Localizable errors #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekdoulik
changed the title
jpobst
reviewed
Aug 25, 2020
Contributor
brendanzagaeski
left a comment
brendanzagaeski
left a comment
There was a problem hiding this comment.
Thanks a bunch for setting all this up! It looks pretty good already. I'll leave a first round of comments with some questions and some ideas about wording adjustments and comments that might help the localization team. I'll be sure to take another look to make sure everything looks good after the messages get code numbers. Thanks!
and warnings messages. Uses the same Java.Interop.Localization assembly as other JI tools for localizable messages.
Also use lower case for error/warning words to be better compatible with our (tasks)[https://github.com/xamarin/xamarin-android/blob/f14890fa2146913afb023a37b6ff4ec62381392a/src/Xamarin.Android.Build.Tasks/Utilities/MSBuildExtensions.cs#L78-L79].
Also turn warning about missing symbols to informational output.
Also change 2 warning to informational output
radekdoulik
force-pushed
the
pr-localizable-errors-and-warnings
branch
from
6ee069f to
79b9edb
Compare
Contributor
brendanzagaeski
left a comment
brendanzagaeski
left a comment
There was a problem hiding this comment.
Nice! Thanks for the changes and additional info on these messages! I'll add one more set of wording ideas to consider, and then we should be close to ready to wrap this up.
brendanzagaeski
approved these changes
Sep 4, 2020
Contributor
brendanzagaeski
left a comment
brendanzagaeski
left a comment
There was a problem hiding this comment.
Looks great! Thanks again for all the work on this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and warnings messages. Uses the same
Java.Interop.Localizationassemblyas other JI tools use for localizable text.
Change some of the warnings into informational output and also extend
some of the warnings with more information how to possibly avoid
the warning.