Invalidate automatically generated events that will have invalid name. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Should we skip it, and not rename it? We could e.g. prefix with |
Contributor
Author
|
Keep it consistent with existing behavior to not bring API changes to customers, as long as it is possible. |
tools/generator/InterfaceGen.cs
Outdated
| continue; | ||
| } | ||
| if (opt.GetSafeIdentifier (name) != name) { | ||
| Report.Warning (0, Report.WarningInterfaceGen + 4, "event name for {0}.{1} is invalid.", FullName, method.Name); |
Contributor
There was a problem hiding this comment.
Warning message should include a way to "fix" the warning, e.g. by explicitly naming it (what's the attribute?).
Contributor
Author
There was a problem hiding this comment.
That is a good point.
Contributor
Author
|
Actually it is fixing only one part of the problem: |
Addresses https://bugzilla.xamarin.com/show_bug.cgi?id=40172 setOn123Listener(On123Listener) will generate event named 123, but that is not a valid C# name and will result in compilation error. So check that name, warn it, and do not generate event.
atsushieno
force-pushed
the
generator-strict-event-name-check
branch
from
fd7c7b7 to
e118a46
Compare
jonpryor
pushed a commit
that referenced
this pull request
Jan 31, 2020
Changes: dotnet/android-tools@66d445c...bfb66f3 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/826178 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/938504 Context: http://feedback.devdiv.io/606218 * dotnet/android-tools@bfb66f3: Update to sdk-style csproj and netstandard2.0. (#78) * dotnet/android-tools@9f4ed4b: Use %ProgramW6432% path for 32-bit apps (#75) * dotnet/android-tools@294f447: Merge pull request #77 from xamarin/dev/soch/fix_certs * dotnet/android-tools@131bb29: Fix authenticode certs * dotnet/android-tools@962c486: Prevent NRE when Android SDK is not found (#73) * dotnet/android-tools@9b03310: [Windows] check %JAVA_HOME% for locating Jdk (#74) * dotnet/android-tools@cb41333: Get OpenJDK from well-known paths, not just registry (#72) * dotnet/android-tools@53ffdae: Downgrade to net46 for compatibility with VS2017+(#69) * dotnet/android-tools@4264703: Add AlternateIds for 9.0 * dotnet/android-tools@90a6e06: [Xamarin.Android.Tools.AndroidSdk] Add 9.0 to KnownVersions. * dotnet/android-tools@4f717b6: Check if the path exists before trying to enumerate it. (#67) Had to add an explicit NuGet restore to build it on Windows because 🤷♂.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://bugzilla.xamarin.com/show_bug.cgi?id=40172
setOn123Listener(On123Listener) will generate event named 123, but that
is not a valid C# name and will result in compilation error. So check
that name, warn it, and do not generate event.