Skip to content

[XAT.Bytecode] Delete some unit tests that were already moved to /tests. #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2020
Merged

[XAT.Bytecode] Delete some unit tests that were already moved to /tests. #603

merged 2 commits into from
Mar 19, 2020

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Mar 17, 2020 •
edited
Loading

These test files for Xamarin.Android.Tools.Bytecode were supposed to be moved to /tests in #517, however they were copied instead. Thus they are duplicated in our tree. This removes the unused copy.

@jpobst jpobst requested a review from jonpryor March 17, 2020 15:12
@jpobst jpobst force-pushed the remove-bytecode-tests branch from 24787d7 to e70082b Compare March 19, 2020 19:21
@jonpryor
Copy link
Contributor

jonpryor commented Mar 19, 2020

Squash-and-merge Title:

[Xamarin.Android.Tools.Bytecode-Tests] Remove obsolete files (#603)

Body:

The files in `src/Xamarin.Android.Tools.Bytecode/Tests/**/*` should
have been removed in commit dec2e390, but were instead *copied* into
`tests/Xamarin.Android.Tools.Bytecode-Tests`.

Delete the directory `src/Xamarin.Android.Tools.Bytecode/Tests`.

@jonpryor
Copy link
Contributor

jonpryor commented Mar 19, 2020

Please remove the file: src/Xamarin.Android.Tools.Bytecode/Tests/Xamarin.Android.Tools.Bytecode-Tests.csproj.

@jonpryor jonpryor merged commit f7ea4ed into master Mar 19, 2020
@jonpryor jonpryor deleted the remove-bytecode-tests branch March 19, 2020 20:19
@jpobst jpobst added this to the d16-7 milestone Apr 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonpryor jonpryor Awaiting requested review from jonpryor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

11.0 (d16-7)

Development

Successfully merging this pull request may close these issues.

3 participants

@jpobst @jonpryor