[build] Remove extraneous nuget restores
#599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever since commit dec2e39, *every* **make**(1) target would result in running `nuget restore`, e.g.: $ make run-tests TESTS=bin/TestDebug/Java.Interop.Tools.JavaSource-Tests.dll nuget restore ... The `nuget restore` was both time consuming and irrelevant, and meant that `make` targets which *should* have been fast -- like `make all`, which shouldn't do anything after the initial `make prepare all`, would instead take multiple seconds to complete. Why was `nuget restore` always being invoked? $ make -d -n run-tests ... Must remake target `packages/NUnit.3.11.0/NUnit.3.11.0.nupkg'. nuget restore What happened is that commit dec2e39 changed various projects to be Short-Form SDK projects, which in turn alters the `packages` directory structure: instead of e.g. packages/NUnit.3.11.0/NUnit.3.11.0.nupkg the file is instead: packages/nunit/3.11.0/nunit.3.11.0.nupkg Note case and directory structure change, which in turn meant that the rule dependencies were *never* satisfied (unless you happened to have a `packages` directory from a pre-dec2e390 build…). We *could* fix up the `$(PACKAGES)` and `$(NUNIT_CONSOLE)` variables to use the new paths, but they're not actually *used* for anything anymore, so just remove them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since commit dec2e39, every make(1) target would result in
running
nuget restore, e.g.:The
nuget restorewas both time consuming and irrelevant, and meantthat
maketargets which should have been fast -- likemake all,which shouldn't do anything after the initial
make prepare all,would instead take multiple seconds to complete.
Why was
nuget restorealways being invoked?What happened is that commit dec2e39 changed various projects to be
Short-Form SDK projects, which in turn alters the
packagesdirectorystructure: instead of e.g.
the file is instead:
Note case and directory structure change, which in turn meant that the
rule dependencies were never satisfied (unless you happened to have
a
packagesdirectory from a pre-dec2e390 build…).We could fix up the
$(PACKAGES)and$(NUNIT_CONSOLE)variablesto use the new paths, but they're not actually used for anything
anymore, so just remove them.