[generator-Tests] Ignore .fixed files
#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3b038a8 broke `make run-tests` because starting with 3b038a8 `generator` would emit an `api.xml.fixed` file into the output directory, which wasn't present in the source directory. This resulted in a unit test execution failures when running `generator-Tests.dll`: generatortests.Adapters.GeneratedOK : Expected out/Adapters/Adapters.xml.fixed but it was not generated. at generatortests.BaseGeneratorTest.CompareOutputs (System.String sourceDir, System.String destinationDir) [0x0004f] in .../Java.Interop/tools/generator/Tests/BaseGeneratorTest.cs:57 at generatortests.BaseGeneratorTest.Run (CodeGenerationTarget target, System.String outputPath, System.String apiDescriptionFile, System.String expectedPath, System.String[] additionalSupportPaths) [0x0004a] in .../Java.Interop/tools/generator/Tests/BaseGeneratorTest.cs:112 at generatortests.BaseGeneratorTest.RunAllTargets (System.String outputRelativePath, System.String apiDescriptionFile, System.String expectedRelativePath, System.String[] additionalSupportPaths) [0x0001c] in .../Java.Interop/tools/generator/Tests/BaseGeneratorTest.cs:95 at generatortests.Adapters.GeneratedOK () [0x0001f] in .../Java.Interop/tools/generator/Tests/Adapters.cs:12 at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&) at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00038] in /private/tmp/source-mono-4.4.0-c7sr0/bockbuild-mono-4.4.0-branch-c7sr0/profiles/mono-mac-xamarin/build-root/mono-x86/mcs/class/corlib/System.Reflection/MonoMethod.cs:295 Fix this error by ignoring the `api.xml.fixed` files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3b038a8 broke
make run-testsbecause starting with 3b038a8generatorwould emit anapi.xml.fixedfile into the outputdirectory, which wasn't present in the source directory. This resulted
in a unit test execution failures when running
generator-Tests.dll:Fix this error by ignoring the
api.xml.fixedfiles.