[xa-fx-cop] Properly ignore Java.Interop assembly errors #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gendarme invocation ignores the `Gendarme.Rules.Design.MarkAssemblyWithCLSCompliantRule` and `Gendarme.Rules.Design.MarkAssemblyWithComVisibleRule` rules because the PCL profile that `Java.Interop.dll` targets doesn't provide the `CLSComplientAttribute` and `ComVislbleAttribute` custom attributes, and so they can't be used. Commit 782f34a "broke" these ignores by signing `Java.Interop.dll`, causing the PublicKeyToken to change. This in turn caused the ignores to be ignored, which meant Gendarme now reported errors: > This assembly is not decorated with the [CLSCompliant] attribute > This assembly is not decorated with the [ComVisible] attribute. Fix the PublicKeyToken in the assembly name so that the rules are properly ignored.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gendarme invocation ignores the
Gendarme.Rules.Design.MarkAssemblyWithCLSCompliantRuleandGendarme.Rules.Design.MarkAssemblyWithComVisibleRulerules becausethe PCL profile that
Java.Interop.dlltargets doesn't provide theCLSComplientAttributeandComVislbleAttributecustom attributes,and so they can't be used.
Commit 782f34a "broke" these ignores by signing
Java.Interop.dll,causing the PublicKeyToken to change. This in turn caused the ignores
to be ignored, which meant Gendarme now reported errors:
Fix the PublicKeyToken in the assembly name so that the rules are
properly ignored.