[generator] Ratchet [Obsolete] *InterfaceConsts classes up to an error. #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveisok
pushed a commit
that referenced
this pull request
Aug 30, 2019
…490) Context: #436 The `*InterfaceConsts` classes we've been generating for ages have been marked as `[Obsolete]` for at least 3 years: [Obsolete ("Use the 'MyInterface' type. This type will be removed in a future release.")] public abstract class MyInterfaceConsts : MyInterface { } It's time to tighten the screws a little bit and make this an error: [Obsolete ("Use the 'MyInterface' type. This type will be removed in a future release.", error: true)] public abstract class MyInterfaceConsts : MyInterface { }
jonpryor
pushed a commit
that referenced
this pull request
Sep 6, 2019
…490) Context: #436 The `*InterfaceConsts` classes we've been generating for ages have been marked as `[Obsolete]` for at least 3 years: [Obsolete ("Use the 'MyInterface' type. This type will be removed in a future release.")] public abstract class MyInterfaceConsts : MyInterface { } It's time to tighten the screws a little bit and make this an error: [Obsolete ("Use the 'MyInterface' type. This type will be removed in a future release.", error: true)] public abstract class MyInterfaceConsts : MyInterface { }
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
*InterfaceConstsclasses we originally generated have been marked as[Obsolete]for at least 3 years:It's time to tighten the screws a little bit and make this an error.
Related to #436.