[generator] Emit new when hiding Handle, Message
#49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal Xamarin.Android CI system is reporting an error when
running the
generatorunit tests, but it's a false positive.It's not a bug in
generator. Rather, it's a bug in Mono 4.2, inwhich
CSharpCodeCompilertreats multi-line warnings as errors.Since the
generatorunit tests emit such multi-line warnings whenhiding
Java.Lang.Object.Handle(viaXamarin.Test.SomeObject.Handle()) andSystem.Exception.Message(via
Java.Lang.Throwable.Message), and Mono 4.2 treats themulti-line warnings as errors, the tests fail.
There are three plausible solutions so that we don't get erroneous
reports from the
generatortests when running on Mono 4.2:generatorso that the warning isn't emitted.(2) would require an unknown timeframe with unknown repercussions.
Thus, the chosen fix: improve
generatorso that the warning isn'tgenerated.