[generator] Don't [Register] a Connector for static properties. #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
static-property-callbacks
branch
2 times, most recently
from
8ab72eb to
30e6957
Compare
jpobst
force-pushed
the
static-property-callbacks
branch
from
30e6957 to
4958946
Compare
steveisok
pushed a commit
that referenced
this pull request
Aug 30, 2019
Default interface member static properties do not need to mention a *connector-method* within the `[Register]` custom attribute. Connector-methods are only for method *overrides*, and static methods cannot be overridden. Additionally, the connector method-related "glue" code isn't emitted, so the connector-method value doesn't exist. Update default interface member static property generation to mirror that of [class static member generation][0] and emit the empty string (`string.Empty`) as the conector method for static properties. [0]: https://github.com/xamarin/java.interop/blob/fe13b1655d8a979f281cf923c97c9e0bf58dc614/tools/generator/Java.Interop.Tools.Generator.CodeGeneration/CodeGenerator.cs#L1376-L1377
jonpryor
pushed a commit
that referenced
this pull request
Sep 6, 2019
Default interface member static properties do not need to mention a *connector-method* within the `[Register]` custom attribute. Connector-methods are only for method *overrides*, and static methods cannot be overridden. Additionally, the connector method-related "glue" code isn't emitted, so the connector-method value doesn't exist. Update default interface member static property generation to mirror that of [class static member generation][0] and emit the empty string (`string.Empty`) as the conector method for static properties. [0]: https://github.com/xamarin/java.interop/blob/fe13b1655d8a979f281cf923c97c9e0bf58dc614/tools/generator/Java.Interop.Tools.Generator.CodeGeneration/CodeGenerator.cs#L1376-L1377
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default interface member static properties do not need to mention a
connector-method within the
[Register]custom attribute.Connector-methods are only for method overrides, and static methods
cannot be overridden.
Additionally, the connector method-related "glue" code isn't emitted,
so the connector-method value doesn't exist.
Update default interface member static property generation to mirror
that of class static member generation and emit the empty string
(
string.Empty) as the conector method for static properties.