[jnimarshalmethod-gen] When using -o DIR, put temp assembly in DIR #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of trying to create it in the location of the original assembly as that might not be writable.
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Should we make this test use -o?
https://github.com/xamarin/java.interop/blob/d39699ff541005c1a95338d4a0df6c642f356e24/Makefile#L175-L178
And then make it fail if all the expected assemblies aren't in the output directory?
Member
Author
|
We might run it twice, so that we test both cases. |
Member
Author
|
build |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jonathanpeppers
approved these changes
Aug 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to create it in the location of the original
assembly as that might not be writable.