[ApiXmlAdjuster] Add additional expected attributes #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#3223 Context: https://jenkins.mono-project.com/job/xamarin-android-pr-pipeline-debug/619/ Commit a30523e breaks the xamarin-android build, as it introduces new XML attributes to `class-parse` output which `Xamarin.Android.Tools.ApiXmlAdjuster` doesn't appreciate: Unhandled Exception: System.Exception: …/xamarin-android/bin/BuildDebug/api/api-10.xml.class-parse (16,7): Element 'class' has an unexpected attribute: 'source-file-name'. Expected attributes are: source-file-name at Xamarin.Android.Tools.ApiXmlAdjuster.XmlUtil.CheckExtraneousAttributes (System.String elementName, System.Xml.XmlReader reader, System.String[] expected) at Xamarin.Android.Tools.ApiXmlAdjuster.JavaApiLoaderExtensions.LoadTypeAttributes (Xamarin.Android.Tools.ApiXmlAdjuster.JavaType type, System.Xml.XmlReader reader, System.String[] otherAllowedAttributes) at Xamarin.Android.Tools.ApiXmlAdjuster.JavaApiLoaderExtensions.Load (Xamarin.Android.Tools.ApiXmlAdjuster.JavaClass kls, System.Xml.XmlReader reader) Update `Xamarin.Android.Tools.ApiXmlAdjuster` so that the new attributes introduced in a30523e are considered acceptable. Additionally, fix the error message so that it *actually* lists the "expected attributes", instead of repeating the *un*-expected attribute.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#3223
Context: https://jenkins.mono-project.com/job/xamarin-android-pr-pipeline-debug/619/
Commit a30523e breaks the xamarin-android build, as it introduces new
XML attributes to
class-parseoutput whichXamarin.Android.Tools.ApiXmlAdjusterdoesn't appreciate:Update
Xamarin.Android.Tools.ApiXmlAdjusterso that the newattributes introduced in a30523e are considered acceptable.
Additionally, fix the error message so that it actually lists the
"expected attributes", instead of repeating the un-expected attribute.