Bumped cecil to mono/cecil@cb6c1ca #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed places that used GenericParameterConstraint assuming it was a TypeReference. Cecil changed GPC to have a TypeReference (ConstraintType) property be available as opposed to inherit from it.
radekdoulik
added a commit
that referenced
this pull request
Aug 13, 2019
This reverts commit 807ed48. This change doesn't play well with XA/master branch, because it uses older cecil version without the API break. I have created mono-2019-08 branch here in Java.Interop for mono/2019-08 specific changes for dotnet/android#3449 integration PR. Changes from mono-2019-08 branch (plus this reverted bump) could be merged to master, once the integration PR is merged to XA.
jonpryor
pushed a commit
that referenced
this pull request
Sep 4, 2019
Commit dotnet/cecil@febbd652 contains an API break, altering the return type of `AssemblyReader.ReadGenericConstraints()` from a `Collection<TypeReference>` to a `GenericParameterConstraintCollection`: - public Collection<TypeReference> ReadGenericConstraints (GenericParameter generic_parameter) + public GenericParameterConstraintCollection ReadGenericConstraints (GenericParameter generic_parameter) Bump to mono/cecil/master@cb6c1ca and fix `AssemblyReader.ReadGenericConstraints()` usage so that the new `GenericParameterConstraint.ConstraintType` is used instead of requiring that `ReadGenericConstraints()` return `TypeReference`s.
jonpryor
pushed a commit
that referenced
this pull request
Sep 6, 2019
Commit dotnet/cecil@febbd652 contains an API break, altering the return type of `AssemblyReader.ReadGenericConstraints()` from a `Collection<TypeReference>` to a `GenericParameterConstraintCollection`: - public Collection<TypeReference> ReadGenericConstraints (GenericParameter generic_parameter) + public GenericParameterConstraintCollection ReadGenericConstraints (GenericParameter generic_parameter) Bump to mono/cecil/master@cb6c1ca and fix `AssemblyReader.ReadGenericConstraints()` usage so that the new `GenericParameterConstraint.ConstraintType` is used instead of requiring that `ReadGenericConstraints()` return `TypeReference`s.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed places that used GenericParameterConstraint assuming it was a TypeReference.
Cecil changed GPC to have a TypeReference (ConstraintType) property be available as opposed to
inherit from it.