[jcw-gen] Generate Java Callable Wrappers in parallel. #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
force-pushed
the
jonp-jcw-gen-tasks
branch
2 times, most recently
from
67c22e4 to
3a417de
Compare
Generate Java Callable Wrappers across multiple tasks.
A note about the tests: when I first added jcw-gen I tried to use
Tasks so I could get parallel JCW generation, but some of the output
was unexpected, in that it would have the wrong package name.
This is why the JavaCallableWrapperGeneratorTests.GenerateInParallel()
test was added: to try to reproduce the error that I recalled seeing.
Doing this found two unexpected bugs in `JniType.ToJniName()` (yay):
1. I was getting a `NullReferenceException` from
`JniType.IsNonStaticInnerClass()`, because in
`JniType.ToJniName<T>()` there is a call to
`JniType.IsNonStaticInnerClass()` using the result of
`as TypeDefinition`, but `IsNonStaticInnerClass()` never checked
for `null`. Oops.
2. The reflection-based `JniType.ToJniName(Type)` overload didn't
check for `Android.App.InstrumentationAttribute` providing an
overriding `InstrumentationAttribute.Name` property.
jonpryor
force-pushed
the
jonp-jcw-gen-tasks
branch
from
3a417de to
f0fa3c3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate Java Callable Wrappers across multiple tasks.