[jnimarshalmethod-gen] Add -p|--profile option #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new option allows to specify which types are processed by a *profile* with the list of types (regex patterns) to process. It is similar to specify multiple `-t` options.
jonpryor
reviewed
Aug 8, 2018
tools/jnimarshalmethod-gen/App.cs
Outdated
| typeNameRegexes.Add (new Regex (line)); | ||
| } | ||
| } catch (Exception e) { | ||
| Error ($"Unable to read profile '{profilePath}'.\n{e}"); |
Contributor
There was a problem hiding this comment.
This is kinda crazy, but I have no idea what a \n is going to do on Windows, especially with our color-altering Error() method. Should this instead use {Environment.NewLine}?
Member
Author
There was a problem hiding this comment.
{Environment.NewLine} makes sense. I will update it (and replace \n in other places too)
Contributor
|
Why does this now have a Cecil bump? |
To look better in Windows environments.
radekdoulik
force-pushed
the
pr-add-profile-option
branch
from
f87e02a to
7f8d655
Compare
Member
Author
|
Ops, updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new option allows to specify which types are processed by a
profile with the list of types (regex patterns) to process.
It is similar to specify multiple
-toptions.