Skip to content

Conversation

@radekdoulik
Copy link
Member

@radekdoulik radekdoulik commented Jul 30, 2018

Create a dictionary of cecil types at the beginning, instead of
searching through the whole module every time we need to find a type.

That saves about 12 seconds from 48, when running it on
Mono.Android.dll

Output of the time command:

Before       47.67 real        47.90 user         2.00 sys
After        35.52 real        35.57 user         2.07 sys

Create a dictionary of cecil types at the beginning, instead of
searching through the whole module every time we need to find a type.

That saves about 12 seconds from 48, when running it on
`Mono.Android.dll`
@radekdoulik radekdoulik requested a review from jonpryor July 30, 2018 09:49
@jonpryor
Copy link
Contributor

hat saves about 12 seconds from 48

In what context? Is this jnimarshalmethod-gen.exe execution time? Something else?

@radekdoulik
Copy link
Member Author

Yes, execution time measured by time command.

Before       47.67 real        47.90 user         2.00 sys
After        35.52 real        35.57 user         2.07 sys

@jonpryor jonpryor merged commit 8298c72 into dotnet:master Jul 30, 2018
jonathanpeppers added a commit to jonathanpeppers/xamarin-android that referenced this pull request Aug 25, 2018
Context: dotnet/java-interop@78f7301...893562c

Use JdkInfo during the build:
dotnet/java-interop#349

Optimize type lookups:
dotnet/java-interop#350

[jnimarshalmethod-gen] --types option:
dotnet/java-interop@d174fa6

Remove unused XAIntegration $(Configuration):
dotnet/java-interop#361

Option to build Java.Interop as non-PCL:
dotnet/java-interop#360
dellis1972 pushed a commit to dotnet/android that referenced this pull request Aug 26, 2018
Context: dotnet/java-interop@78f7301...893562c

Use JdkInfo during the build:
dotnet/java-interop#349

Optimize type lookups:
dotnet/java-interop#350

[jnimarshalmethod-gen] --types option:
dotnet/java-interop@d174fa6

Remove unused XAIntegration $(Configuration):
dotnet/java-interop#361

Option to build Java.Interop as non-PCL:
dotnet/java-interop#360
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants