Don't omit the extended API description attributes #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
force-pushed
the
lost-attributes
branch
from
cb6a65a to
a9c7dd4
Compare
class-parse emits a number of useful attributes which contain information about the JNI signatures, return and parameter types etc. Currently, API XML adjuster removes them from its output. The information in extended attributes is (will be) useful for code generation and thus this commit makes sure that all of them made it to the adjusted XML.
grendello
force-pushed
the
lost-attributes
branch
from
a9c7dd4 to
711dd63
Compare
jonpryor
pushed a commit
that referenced
this pull request
Aug 2, 2018
`class-parse` emits a number of useful attributes which contain information about the JNI signatures, return and parameter types etc. Currently, API XML adjuster removes them from its output. The information in extended attributes is (will be) useful for code generation and thus this commit makes sure that all of them made it to the adjusted XML.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class-parse emits a number of useful attributes which contain information about
the JNI signatures, return and parameter types etc. Currently, API XML adjuster
removes them from its output.
The information in extended attributes is (will be) useful for code generation
and thus this commit makes sure that all of them made it to the adjusted XML.