Skip to content

[Java.Interop] Checked remaining disposed exception defects #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2018
Merged

[Java.Interop] Checked remaining disposed exception defects #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions gendarme-ignore.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ M: Java.Interop.JniType Java.Interop.JniType::GetSuperclass()
M: System.Boolean Java.Interop.JniType::IsAssignableFrom(Java.Interop.JniType)
M: System.Boolean Java.Interop.JniType::IsInstanceOfType(Java.Interop.JniObjectReference)
M: System.Void Java.Interop.JniType::RegisterNativeMethods(Java.Interop.JniNativeMethodRegistration[])
M: System.Void Java.Interop.JniType::RegisterWithRuntime()
M: System.Void Java.Interop.JniType::UnregisterNativeMethods()
M: Java.Interop.JniMethodInfo Java.Interop.JniType::GetConstructor(System.String)
M: Java.Interop.JniMethodInfo Java.Interop.JniType::GetCachedConstructor(Java.Interop.JniMethodInfo&,System.String)
Expand All @@ -278,6 +279,13 @@ M: Java.Interop.JniMethodInfo Java.Interop.JniType::GetCachedInstanceMethod(Java
M: Java.Interop.JniMethodInfo Java.Interop.JniType::GetStaticMethod(System.String,System.String)
M: Java.Interop.JniMethodInfo Java.Interop.JniType::GetCachedStaticMethod(Java.Interop.JniMethodInfo&,System.String,System.String)

# do not check here to improve performance
M: System.Void Java.Interop.JniArrayElements::CopyToJava()
M: System.Int32 Java.Interop.JavaObjectArray`1::IndexOf(T)
M: Java.Interop.JniArrayElements Java.Interop.JavaPrimitiveArray`1::GetElements()

# it doesn't make sense to check the disposed state here, as the JavaObject::Dispose(bool) doesn't do anything and neither the JavaArray nor JavaObjectArray override it
M: System.Void Java.Interop.JavaObjectArray`1::set_Item(System.Int32,T)

R: Gendarme.Rules.Interoperability.MarshalBooleansInPInvokeDeclarationsRule
# These aren't `bool`, they're `bool*`, which is a *huge* difference!
Expand Down