[tests] fix for ANDROID_SDK_PATH #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/xamarin/xamarin-android/blob/master/build-tools/scripts/RunTests.targets#L50 Context: https://devdiv.visualstudio.com/DevDiv/Default/_build/index?buildId=1138588&_a=summary&tab=ms.vss-test-web.test-result-details On Windows, the Java.Interop tests are not getting the `ANDROID_SDK_PATH` environment variable set. This is somehow working on macOS, but I think it might be simpler in this case to pass in the `AndroidSdkDirectory` property from `RunTests.targets` in xamarin-android. This approach worked when testing locally. I will need to bump Java.Interop and make one further change in xamarin-android to pass in `AndroidSdkDirectory`. This will get a few skipped tests in Java.Interop running and passing on Windows.
|
@jonathanpeppers, |
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Nov 14, 2017
Context: dotnet/java-interop#211 Looking to fix `ANDROID_SDK_PATH` not set in tests on Windows.
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Nov 15, 2017
Context: dotnet/java-interop#211 Looking to fix `ANDROID_SDK_PATH` not set in tests on Windows.
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Nov 17, 2017
Context: dotnet/java-interop#211 For Windows to set `ANDROID_SDK_PATH` for the Java.Interop unit tests, we need to pass `$(AndroidSdkDirectory)` through. Otherwise a few tests get skipped in Xamarin.Android.Tools.Bytecode-Tests.dll.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/xamarin-android/blob/master/build-tools/scripts/RunTests.targets#L50
Context: https://devdiv.visualstudio.com/DevDiv/Default/_build/index?buildId=1138588&_a=summary&tab=ms.vss-test-web.test-result-details
On Windows, the Java.Interop tests are not getting the
ANDROID_SDK_PATHenvironment variable set. This is somehow working on macOS, but I think
it might be simpler in this case to pass in the
AndroidSdkDirectoryproperty from
RunTests.targetsin xamarin-android.This approach worked when testing locally. I will need to bump Java.Interop
and make one further change in xamarin-android to pass in
AndroidSdkDirectory. This will get a few skipped tests in Java.Interoprunning and passing on Windows.