[tests] adding missing copy command to MSBuild test targets #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/xamarin/java.interop/blob/master/Makefile#L149 When we ported the NUnit tests from `Makefile` to `MSBuild`, there was a target missing that copies `libjava-interop.dylib` from `bin/Debug` to `bin/TestDebug`. It went unnoticed on Windows, because these tests are not passing yet there.
|
@jonathanpeppers, |
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Nov 10, 2017
Context: dotnet/java-interop#209 This should resolve the broken unit tests on the master Jenkins job.
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Nov 11, 2017
Context: dotnet/java-interop#209 This should resolve the broken unit tests on the master Jenkins job.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
https://github.com/xamarin/java.interop/blob/master/Makefile#L149
When we ported the NUnit tests from
MakefiletoMSBuild, there wasa target missing that copies
libjava-interop.dylibfrombin/Debugto
bin/TestDebug. It went unnoticed on Windows, because these testsare not passing yet there.