[generator] fix bogus type name in warnings for duplicate fields. #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It had annoyed me by reporting warnings on android.app.Notification.Action as "Android.App.Action", which doesn't exist. It was due to careless use of GenBase.Name combined with GenBase.Namespace which never cared about nested types.
Redth
pushed a commit
to Redth/java.interop
that referenced
this pull request
Oct 26, 2017
…tnet#191) It had annoyed me by reporting warnings on android.app.Notification.Action as "Android.App.Action", which doesn't exist. It was due to careless use of GenBase.Name combined with GenBase.Namespace which never cared about nested types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had annoyed me by reporting warnings on android.app.Notification.Action
as "Android.App.Action", which doesn't exist. It was due to careless use of
GenBase.Name combined with GenBase.Namespace which never cared about nested
types.