[generator] Don't register invariant+excluded types #177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#732
Commit d7dfa0b broke the
xamarin-android/tests/CodeGen-Binding/Xamarin.Android.McwGen-Testsbuild, as it started treating
Android.Graphics.Coloras a normaltype, instead of the special-cased behavior it should have:
The problem is that this code pattern:
became:
The cause reason for this is that d7dfa0b updated
SymbolTable.AddType()so that it no longer calledSymbolTable.ShouldAddType(), which is what would preventtype registration of
Android.Graphics.Color.Reintroduce the call to
ShouldAddType()so thatAndroid.Graphics.Colorisn't registered.