[generator] reduce error-prone enumification XPath. #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, we (well, I) had been patient to deal with methodmap enumification which *requires* distinction between class and interface by adding "[Interface]" mark on interfaces. It was just to distinguish "class" and "interface" elements under "package" element. But... why do we need that? Performance? The impact should be actually trivial. It can be just anything, we identify an element by @name. On the other hand, it is very annoying to exactly specify "class" or "interface" very carefully, because if I make a mistake then the mapping results in a warning that then I have to carefully check. Just reduce such chances for errors by requiring less-error-prone XPath. It should save everyone.
atsushieno
added a commit
to atsushieno/java.interop
that referenced
this pull request
Aug 7, 2017
Until now, we (well, I) had been patient to deal with methodmap enumification which *requires* distinction between class and interface by adding "[Interface]" mark on interfaces. It was just to distinguish "class" and "interface" elements under "package" element. But... why do we need that? Performance? The impact should be actually trivial. It can be just anything, we identify an element by @name. On the other hand, it is very annoying to exactly specify "class" or "interface" very carefully, because if I make a mistake then the mapping results in a warning that then I have to carefully check. Just reduce such chances for errors by requiring less-error-prone XPath. It should save everyone.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we (well, I) had been patient to deal with methodmap enumification
which requires distinction between class and interface by adding
"[Interface]" mark on interfaces. It was just to distinguish "class" and
"interface" elements under "package" element.
But... why do we need that? Performance? The impact should be actually
trivial. It can be just anything, we identify an element by @name.
On the other hand, it is very annoying to exactly specify "class" or
"interface" very carefully, because if I make a mistake then the mapping
results in a warning that then I have to carefully check.
Just reduce such chances for errors by requiring less-error-prone XPath.
It should save everyone.