[build] Prefer JDK-17 #1291
Merged
[build] Prefer JDK-17 #1291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android@df68c20 dotnet/android requires JDK-17, as of dotnet/android@df68c208. Update the dotnet/java-interop build to prefer JDK-17, for consistency. Additionally, *replace* use of `javac -source X -target X` with `javac --release X`, as this removes a build warning: EXEC : warning : [options] system modules path not set in conjunction with -source 11
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
New JDK, new `.class` output.
Context: 7a32bb9 Context: https://bugs.openjdk.org/browse/JDK-8223291 JDK-8223291 was fixed in JDK-14, which is presumably why XML output changed. Again. Update expected XML reference files so that tests pass with JDK-17. (Which means these tests will *only* pass with JDK-17, and later if we're lucky, but will *fail* with JDK-11.)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (6)
- Directory.Build.props: Language not supported
- build-tools/scripts/Prepare.targets: Language not supported
- tools/java-source-utils/src/test/resources/UnresolvedTypes.xml: Language not supported
- tools/java-source-utils/src/test/resources/com/microsoft/android/DemoInfo.xml: Language not supported
- tools/java-source-utils/src/test/resources/com/microsoft/android/JavaType.xml: Language not supported
- tools/java-source-utils/src/test/resources/com/microsoft/android/Outer.xml: Language not supported
jpobst
approved these changes
Jan 11, 2025
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Jan 13, 2025
Changes: dotnet/java-interop@ee47652...4f06201 * dotnet/java-interop@4f06201b: [build] Prefer JDK-17 (dotnet/java-interop#1291) * dotnet/java-interop@b966c15b: [java-source-utils] Flush VSCode changes (dotnet/java-interop#1289) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android@df68c20
dotnet/android requires JDK-17, as of dotnet/android@df68c208.
Update the dotnet/java-interop build to prefer JDK-17, for consistency.
Additionally, replace use of
javac -source X -target Xwithjavac --release X, as this removes a build warning: