[build] main *conceptually* targets .NET 10
#1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 356485e `Java.Interop.dll` assembly version is now 10.0. With 356485e significantly changing `generator` output, without a corresponding `generator --lang-features` or equivalent switch to revert behavior, it feels "safer" to bump the assembly version *now* to reduce the likelihood of inadvertent assembly mixing. (Not that I'm arguing that we *should* have such a flag. We absolutely need to move away from requiring System.Reflection.Emit.)
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Dec 6, 2024
Fixes: dotnet/java-interop#1258 Changes: dotnet/java-interop@2440416...2d48efe * dotnet/java-interop@2d48efe7: [build] `main` *conceptually* targets .NET 10 (dotnet/java-interop#1283) * dotnet/java-interop@356485ee: [generator] Remove `JNINativeWrapper.CreateDelegate` from bindings (dotnet/java-interop#1275) * dotnet/java-interop@14f94a57: [Java.Interop.BootstrapTasks] Filter out invalid JDKs (dotnet/java-interop#1278) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 356485e
Java.Interop.dllassembly version is now 10.0.With 356485e significantly changing
generatoroutput, without a correspondinggenerator --lang-featuresor equivalent switch to revert behavior, it feels "safer" to bump the assembly version now to reduce the likelihood of inadvertent assembly mixing.(Not that I'm arguing that we should have such a flag. We absolutely need to move away from requiring System.Reflection.Emit.)