[generator-Tests] bind java.util.List #1273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 0aec86a Commit 0aec86a mentioned: > Remaining Integration-Tests which don't support JavaInterop1: > > * Missing builtin mapping between collection types: > > warning BG8800: Unknown parameter type 'java.util.List<java.lang.Integer>' for member … > warning BG8800: Unknown parameter type 'java.util.ArrayList<java.lang.Integer>' for member > warning BG8400: Unexpected field type `java.util.List<java.lang.String>` > > Impacts: Java_Util_List.cs, NormalMethods.cs, ParameterXPath.cs The problem here is that the provided API XML did not contain a declaration for `java.util.List<E>`. This didn't matter for XAJavaInterop1 output, as it binds `List<E>` as `System.Collections.Generic.IList<T>`, but it *does* matter for JavaInterop1 output, as it doesn't special-case `List<E>`. (Perhaps it should! Or this helps "lower" the need for improved generics! Or…) Add a declaration for `java.util.List<E>` to Java_Util_List.cs, and ParameterXPath.cs, so that we can set `TryJavaInterop1 => true`. Also add a declaration for `java.util.List<E>` to NormalMethods.cs. This doesn't allow us to enable `TryJavaInterop1 => true`, because of the "`Handle` isn't a public property" issue, but it'll be a necessary prerequisite to enable NormalMethods.cs in the future.
jpobst
approved these changes
Oct 24, 2024
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Oct 25, 2024
Changes: dotnet/java-interop@2a1e180...87fdb8e * dotnet/java-interop@87fdb8e6: [generator-Tests] bind java.util.List (dotnet/java-interop#1273) * dotnet/java-interop@32506ce5: Bump to dotnet/android-tools@60fae19 (dotnet/java-interop#1270) * dotnet/java-interop@53079086: [Java.Base] Update to Microsoft.DotNet.GenAPI 8.0.0-beta.24516.1 (dotnet/java-interop#1272) * dotnet/java-interop@0aec86ac: [generator-Tests] Enable JavaInterop1 Integration output tests (dotnet/java-interop#1271) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 0aec86a
Commit 0aec86a mentioned:
The problem here is that the provided API XML did not contain a declaration for
java.util.List<E>. This didn't matter for XAJavaInterop1 output, as it bindsList<E>asSystem.Collections.Generic.IList<T>, but it does matter for JavaInterop1 output, as it doesn't special-caseList<E>. (Perhaps it should! Or this helps "lower" the need for improved generics! Or…)Add a declaration for
java.util.List<E>to Java_Util_List.cs, and ParameterXPath.cs, so that we can setTryJavaInterop1 => true.Also add a declaration for
java.util.List<E>to NormalMethods.cs. This doesn't allow us to enableTryJavaInterop1 => true, because of the "Handleisn't a public property" issue, but it'll be a necessary prerequisite to enable NormalMethods.cs in the future.