[generator] add [IntDefinition (JniField = ...)] everywhere. #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Unit test failure. You likely need to add a |
atsushieno
force-pushed
the
add-int-definition-everywhere
branch
2 times, most recently
from
de7fadb to
6aebca5
Compare
jonpryor
reviewed
Feb 16, 2017
| namespace Android.Runtime | ||
| { | ||
| [AttributeUsage (AttributeTargets.Field)] | ||
| public class IntDefinitionAttribute : Attribute |
Contributor
There was a problem hiding this comment.
This seems odd; why do you need this type in both expected and expected.cp? The version in SupportFiles should be enough, no?
Contributor
Author
There was a problem hiding this comment.
I thought adding those fixed the tests? Maybe it was fixed rather by cleaning up files. Anyways they are removed now.
atsushieno
force-pushed
the
add-int-definition-everywhere
branch
from
6aebca5 to
282472e
Compare
jonpryor
reviewed
Feb 17, 2017
| @@ -1,5 +1,6 @@ | |||
| namespace Android.Text { | |||
| public enum SpanTypes { | |||
| [global::Android.Runtime.IntDefinition (null, JniField = "I:android/text/Spanned.SPAN_COMPOSING")] | |||
Contributor
There was a problem hiding this comment.
I'm still not clear on why some of these values have a type prefix -- I: -- and some don't.
Perhaps the type should be separated from the member name, for simplicity?
[IntDefinition (JniSourceFieldType="I", JniSourceDeclaringType="android/text/Spanned", JniSourceFieldMember="SPAN_COMPOSING")]
Perhaps the type+member can be combined with a . separator, but I'm not sure we should have <jni-type>: as an optional prefix.
Contributor
Author
There was a problem hiding this comment.
WTF. Those "I:" are actually from map.csv to indicate that the type is an interface (not a class), which should not have been required from the beginning. I made a change that kills those "I:" prefixes.
It will be helpful when people read binding dlls and understand the enum conversion, as well as tooling.
atsushieno
force-pushed
the
add-int-definition-everywhere
branch
from
282472e to
b12575a
Compare
jonpryor
pushed a commit
that referenced
this pull request
Oct 4, 2021
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1314263 Context: c936d09 Changes: dotnet/android-tools@d92fc3e...34e98e2 * dotnet/android-tools@34e98e2: [build] Allow Assembly "vendorization" (#136) * dotnet/android-tools@061bcc2: [build] Import "parent directory.override.targets" (#135) * dotnet/android-tools@a5194e9: [Xamarin.Android.Tools.AndroidSdk] Downgrade build-tools to API-30 * dotnet/android-tools@440e6be: [Xamarin.Android.Tools.AndroidSdk] Update SDK component for API-31 (#134) * dotnet/android-tools@9b658b2: Merge pull request #133 from xamarin/ndk-r23 * dotnet/android-tools@ff73f92: [build] Use GitInfo to generate $(Version) (#131) * dotnet/android-tools@4c2e36c: [Xamarin.Android.Tools.AndroidSdk] Eclipse Adoptium support (#132) * dotnet/android-tools@eaec4e3: [Xamarin.Android.Tools.AndroidSdk] More Microsoft Dist JDK Support (#130) * dotnet/android-tools@f9c1b0d: [BaseTasks] improve Task settings in AsyncTaskExtensions (#129) * dotnet/android-tools@efc9b67: Merge pull request #128 from dellis1972/bumpitybump * dotnet/android-tools@40adec0: Bump LibZipSharp and Mono.Unix to latest stable versions, * dotnet/android-tools@87acd6b: [Microsoft.Android.Build.BaseTasks] add StrongName (#127) * dotnet/android-tools@02f7ae7: [NDK] Properly detect 64-bit NDK * dotnet/android-tools@623332d: Bump LibZipSharp to 2.0.0-alpha7 (#126) * dotnet/android-tools@c055fa8: [Microsoft.Android.Build] Bump to MSBuild 16.10.0 (#125) * dotnet/android-tools@49936d6: Merge pull request #124 from xamarin/update-libzipsharp * dotnet/android-tools@ef78dfc: Bump LibZipSharp to 2.0.0-alpha6 * dotnet/android-tools@e3d708c: [BaseTasks] fix `\`-delimited paths on macOS (#122) * dotnet/android-tools@bdcf899: Reference the new Mono.Unix nuget (#123) * dotnet/android-tools@90d7621: [BaseTasks] add ABI detection for RIDs (#121) * dotnet/android-tools@79e3b97: [JdkInfo] handle invalid XML from /usr/libexec/java_home (#120) * dotnet/android-tools@81519fe: Add SECURITY.md (#119) * dotnet/android-tools@683f375: [Microsoft.Android.Build] Use MSBuild NuGets (#118) * dotnet/android-tools@2241489: [Xamarin.Android.Tools.AndroidSdk] Support Microsoft Dist JDK (#117) * dotnet/android-tools@52ef989: [Xamarin.Android.Tools.AndroidSdk] Fix CS0168 warning (#116) Moving the Roslyn Analyzers initialization code from `Directory.Build.props` to `Directory.Build.targets` (c936d09) caused the Roslyn Analyzers to be applied to code imported from `external/xamarin-android-tools`. Previously the xamarin-android-tools code was unaffected because it had its own `Directory.Build.props` file, so it did not traverse the file system upwards any further to find the Java.Interop files. Fixes for Roslyn issues has not been applied to `xamarin-android-tools` code, so it adds ~150 warnings to the Java.Interop build. dotnet/android-tools@ff73f925 added a `Directory.Build.targets`, so updating `external/xamarin-android-tools` to the latest xamarin-android-tools commit will prevent Java.Interop's `Directory.Build.targets` file from being used, which will exclude xamarin-android-tools from the Roslyn Analyzers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS WITHOUT MERGING dotnet/android#444, it depends on Mono.Android.dll updates.
It will be helpful when people read binding dlls and understand the enum
conversion, as well as tooling.