[generator] Override methods should match base method's deprecated info. #1130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several warnings when building
Mono.Android.dllrelated toObsoletemethods:Technically,
MediaRouteActionProvider.onCreateActionViewis marked asdeprecatedin the docs, but not in the compiledandroid.jar:Regardless, any method that overrides a deprecated method should itself be marked as deprecated.
Another case specific to
Mono.Android.dllis ContextWrapper.setWallpaperThis method is marked as
deprecated-since=23, but the base method is marked asdeprecated-since=16. This causes us to generate:This causes the same warning. For these cases, we set the
overridemethod'sdeprecated-sinceto match the base method.