Skip to content

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented May 18, 2023

Clean up some things in .csproj files that are no longer needed:

  • <PackageReference> Microsoft.NETFramework.ReferenceAssemblies was only needed to build net472
  • <LangVersion> was only needed to use a newer version of C# than older frameworks technically supported. By default, each project uses the version of C# that ships with its TargetFramework.
  • Remove pre-SDK-style csproj properties like <ProjectGuid>.
  • Remove net472-based Conditions.
  • Use consistent whitespace.

@jpobst jpobst marked this pull request as ready for review May 19, 2023 01:09
@jpobst jpobst requested a review from jonpryor May 19, 2023 01:09
@jonpryor jonpryor merged commit bf8d78f into main May 22, 2023
@jonpryor jonpryor deleted the csproj-cleanup branch May 22, 2023 19:42
jonpryor pushed a commit to dotnet/android that referenced this pull request May 24, 2023
Changes: dotnet/java-interop@be2acbc...93c50fe

  * dotnet/java-interop@93c50fef: LEGO: Merge pull request 1115
  * dotnet/java-interop@bf8d78fb: [build] Clean up obsolete portions of csproj files (dotnet/java-interop#1112)
  * dotnet/java-interop@56d30f12: LEGO: Merge pull request 1113

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants