[ci] Enable CodeQL static analysis. #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcollins
reviewed
Nov 7, 2022
| 1ESWindowsImage: AzurePipelinesWindows2022compliant | ||
| 1ESMacPool: Azure Pipelines | ||
| 1ESMacImage: internal-macos-11 | ||
| Codeql.Enabled: true |
There was a problem hiding this comment.
We may want to limit the variable scope since the pipeline has four jobs that include a product build and would potentially run these steps.
Could we set this at a job scope below instead, maybe on the Windows .NET Build here https://github.com/xamarin/java.interop/blob/main/build-tools/automation/azure-pipelines.yaml#L88?
pjcollins
approved these changes
Nov 7, 2022
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Nov 8, 2022
Changes: dotnet/java-interop@5318261...c6c487b * dotnet/java-interop@c6c487b6: [Java.Interop] Optional "Standalone" Build Config (dotnet/java-interop#1049) * dotnet/java-interop@5a0097b5: [ci] Enable CodeQL static analysis. (dotnet/java-interop#1057) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
CodeQLstatic code analysis on this repository to help catch potential issues.This will only run on the
Windows - .NET Corebuild lane, as we do not want to run it on all 4 builds.Note the analysis only runs on
mainbuilds, so it will not show up in this CI build.