Skip to content

Commit 27c9436

Browse files
committed
[generator] makr as DIM overrides as virtual.
There were handful of ABI compatibility regressions that DIM overrides are marked as final. They are intended to be kept virtual, so explicitly mark them as virtual. Although they should be virtual (DIM specification-wise).
1 parent 937cb40 commit 27c9436

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/generator/CodeGenerator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1084,7 +1084,7 @@ public void WriteMethod (Method method, TextWriter writer, string indent, CodeGe
10841084

10851085
string static_arg = method.IsStatic ? " static" : String.Empty;
10861086
bool is_explicit = opt.SupportDefaultInterfaceMethods && type.IsInterface && method.OverriddenInterfaceMethod != null;
1087-
string virt_ov = is_explicit ? string.Empty : method.IsOverride ? (opt.SupportDefaultInterfaceMethods && method.OverriddenInterfaceMethod != null ? "/*DIM override*/" : " override") : method.IsVirtual ? " virtual" : String.Empty;
1087+
string virt_ov = is_explicit ? string.Empty : method.IsOverride ? (opt.SupportDefaultInterfaceMethods && method.OverriddenInterfaceMethod != null ? "/*DIM override*/ virtual" : " override") : method.IsVirtual ? " virtual" : String.Empty;
10881088
if ((string.IsNullOrEmpty (virt_ov) || virt_ov == " virtual") && type.RequiresNew (method.AdjustedName)) {
10891089
virt_ov = " new" + virt_ov;
10901090
}

0 commit comments

Comments
 (0)