Skip to content

Commit 937cb40

Browse files
committed
[generator] add some code comment for future understanding.
1 parent e851944 commit 937cb40

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tools/generator/MethodBase.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ public abstract string Deprecated {
3030
get;
3131
}
3232

33+
// FIXME: this is semantically incorrect. A generic method should rather be evaluated as:
34+
// GenericArguments != null && GenericArguments.Count > 0.
35+
// However, changing this part like this causes various build errors especially with Java.Lang.Enum and other various generic parameter resolution,
36+
// so we should leave this as is (maybe renaming this is an option, in case we want keep using this generator).
3337
public virtual bool IsGeneric {
3438
get { return parms.HasGeneric; }
3539
}

0 commit comments

Comments
 (0)