Skip to content

Conversation

@directhex
Copy link

customEnvVars="$customEnvVars ROOTFS_DIR=${{ parameters.crossRootFs}}"
if [[ '${{ parameters.targetArchitecture }}' != 'wasm' ]]; then
customEnvVars="$customEnvVars CROSSCOMPILE=1"
fi
Copy link
Member

@akoeplinger akoeplinger Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which issues does setting CROSSCOMPILE cause on wasm?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some logic in gen-buildsys i think which sees CROSSCOMPILE=1 and does a build for $BuildOS-$TargetArch instead of $TargetOS-$TargetArch, something like that, anyway it fails on "linux-wasm isn't a thing"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, would you mind filing an issue for this? I'd rather fix this in runtime than hardcoding this logic in the VMR (it's fine for now).

- name: androidCrossContainer
value: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-cross-android-amd64
- name: wasmCrossContainer
value: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-webassembly-20230917141449-2aaa02c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we pinned this version because of some issue in runtime but we should get back to the floating tag ASAP, do you know if we have an issue?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I just pulled what was in my runtime checkout. I'll ask someone from the wasm team tomorrow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet/runtime#92243 was the last time it was touched. IIRC there was some issue with mariner and the libc for one of the wasm deps??

@lewing lewing merged commit 1cebefe into dotnet:main Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Vertical Build for Wasi-Wasm Mono Implement Vertical Build for Browser-Wasm Mono

3 participants