Remove unused legacy PB_ properties

[mmitche]

No description provided.

[mmitche]

@marcpopMSFT Still getting these issues with SupportsTargetFramework pretty often:

 Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAHelloWorldProject.It_publishes_self_contained_apps_to_the_publish_folder_and_the_app_should_run(targetFramework: \"net8.0\")
System.IndexOutOfRangeException : Index was outside the bounds of the array.
   at Microsoft.NET.TestFramework.EnvironmentInfo.SupportsTargetFramework(String targetFramework) in /_/src/Tests/Microsoft.NET.TestFramework/EnvironmentInfo.cs:line 57
   at Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAHelloWorldProject.It_publishes_self_contained_apps_to_the_publish_folder_and_the_app_should_run(String targetFramework) in /_/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs:line 78
   at InvokeStub_GivenThatWeWantToPublishAHelloWorldProject.It_publishes_self_contained_apps_to_the_publish_folder_and_the_app_should_run(Object, Object, IntPtr*)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

What should we do about them?

[marcpopMSFT]

@marcpopMSFT Still getting these issues with SupportsTargetFramework pretty often:

 Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAHelloWorldProject.It_publishes_self_contained_apps_to_the_publish_folder_and_the_app_should_run(targetFramework: \"net8.0\")
System.IndexOutOfRangeException : Index was outside the bounds of the array.
   at Microsoft.NET.TestFramework.EnvironmentInfo.SupportsTargetFramework(String targetFramework) in /_/src/Tests/Microsoft.NET.TestFramework/EnvironmentInfo.cs:line 57
   at Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAHelloWorldProject.It_publishes_self_contained_apps_to_the_publish_folder_and_the_app_should_run(String targetFramework) in /_/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs:line 78
   at InvokeStub_GivenThatWeWantToPublishAHelloWorldProject.It_publishes_self_contained_apps_to_the_publish_folder_and_the_app_should_run(Object, Object, IntPtr*)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

What should we do about them?

@mmitche I thought originally we were only seeing these in older branches and were just going to ignore/disable the test. However, this is in main. We really need nuget to investigate as the line it's failing on is just parsing the TFM with nuget: NuGetFramework.Parse(targetFramework); Is there a chance the test results are flagging the wrong line that's failing as I'm surprised the callstack doesn't include nuget.

@aortiz-msft , is there someone who can take a look at this as we started seeing failures only on Darwin legs and not every time where parsing the target framework is throwing an out of range exception.