Skip to content

Conversation

@lbussell
Copy link
Member

Part of dotnet/source-build#2708

We initially created this patch for runtime's release/6.0 branch to work around some reliability issues with package validation: dotnet/runtime#60881

I ported this patch to main but apparently the reliability issues were fixed a while ago: dotnet/runtime#63601 (comment). As a result, this patch isn't necessary anymore.

@lbussell lbussell marked this pull request as ready for review January 11, 2022 16:36
@lbussell lbussell requested a review from a team as a code owner January 11, 2022 16:36
@MichaelSimons
Copy link
Member

@lbussell - Can you link to the runtime PR that address the stability issues? What branch were these made in? I am wondering if they were backported to 6.0.

@lbussell
Copy link
Member Author

lbussell commented Jan 11, 2022

Here is where the patch was merged into release/6.0.

Here is the issue we were using to track backporting the flaky build fixes that can probably be closed now (edit: it should not be closed, the changes have not been backported to 6.0). It links to two PRs (dotnet/runtime#60847, dotnet/sdk#22277) that have been merged that seem to address the issue.

@lbussell lbussell merged commit 339471a into dotnet:main Jan 11, 2022
@safern
Copy link
Member

safern commented Jan 11, 2022

I am wondering if they were backported to 6.0.

We haven't backported them to 6.0. I will work on that for the 6.0.3 release. I'll let you know so that you can remove the patch on 6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants